WebHost: noscript faq and glossary #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: webhost
Berserker66
changed the title
black-sliver
requested changes
Oct 16, 2024
WebHostLib/requirements.txt
Outdated
| @@ -9,3 +9,4 @@ bokeh>=3.1.1; python_version <= '3.8' | |||
| bokeh>=3.4.3; python_version == '3.9' | |||
| bokeh>=3.5.2; python_version >= '3.10' | |||
| markupsafe>=2.1.5 | |||
| Markdown>=3.7 | |||
There was a problem hiding this comment.
also missing newline at end of file here
Berserker66
commented
Oct 16, 2024
Berserker66
added
the
is: bug/fix
|
Adding bugfix tag as the pages don't work for some users currently. |
|
Hm, it now renders correctly, but there is still a slight difference in the DOM. I'm gonna have one more looksie |
black-sliver
requested changes
Oct 16, 2024
Co-authored-by: black-sliver <[email protected]>
black-sliver
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Link to the discord thread: https://discord.com/channels/731205301247803413/1295539478454079498/1296211476826292304
|
Do these pages still auto-scroll to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Makes /faq and /glossary work with noscript/uMatrix and similar, by not using JS anymore and rendering the md to html on server.
How was this tested?
locally
If this makes graphical changes, please attach screenshots.
I did not see a difference, which is the point.